Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding types on MockHandler fixes various issues #2499

Merged
merged 3 commits into from
Dec 28, 2019
Merged

Adding types on MockHandler fixes various issues #2499

merged 3 commits into from
Dec 28, 2019

Conversation

gmponos
Copy link
Member

@gmponos gmponos commented Dec 23, 2019

This might conflict with #2495 but I will handle it..

@gmponos
Copy link
Member Author

gmponos commented Dec 23, 2019

@sagikazarmark and @Tobion commit ac28f4e failed https://github.com/guzzle/guzzle/pull/2499/checks?check_run_id=361496418

The message is weird.. Should the CurlMultiHandlerTest use the MockHandler

@gmponos gmponos changed the title Making type of MockHandler strict fixes various issues Adding types on MockHandler fixes various issues Dec 23, 2019
@gmponos gmponos added this to the 7.0.0 milestone Dec 28, 2019
Nyholm
Nyholm approved these changes Dec 28, 2019
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit 67f3aa0 into guzzle:master Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gmponos @Nyholm