Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use error level for logging errors in Middleware #2629

Merged
merged 4 commits into from
May 28, 2020
Merged

Use error level for logging errors in Middleware #2629

merged 4 commits into from
May 28, 2020

Conversation

umpirsky
Copy link
Contributor

No description provided.

Nyholm
Nyholm approved these changes May 23, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Nyholm
Nyholm requested changes May 23, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I changed my mind.

So currently you can set the log level on successful logs only. Exceptions are fixed.

I think this PR should be updated to use error on exceptions.

@umpirsky umpirsky changed the title Respect logging level in Middleware Use error level for logging errors in Middleware May 26, 2020
@umpirsky umpirsky requested a review from Nyholm May 26, 2020 07:26
Nyholm
Nyholm approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm added this to the 7.0.0-RC 1 milestone May 26, 2020
@gmponos gmponos merged commit bb71627 into guzzle:master May 28, 2020
@gmponos gmponos mentioned this pull request May 28, 2020
Merged
@umpirsky umpirsky deleted the patch-1 branch May 28, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

@gmponos gmponos gmponos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0-RC 1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@umpirsky @Nyholm @gmponos