Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix progress parameter type compatibility between cURL and StreamHandler #2936

Merged
merged 1 commit into from Oct 7, 2021

Conversation

TimWolla
Copy link
Contributor

@TimWolla TimWolla commented Sep 28, 2021

Unknown values of the progress called are filled with 0 by cURL and in fact
the CURLOPT_PROGRESSFUNCTION parameters are explicitly typed int in
CurlFactory.

StreamHandler always provided null as the upload progress, because the
progress is not known there. Adjust this to 0 for consistent behavior.

Unknown values of the progress called are filled with `0` by cURL and in fact
the `CURLOPT_PROGRESSFUNCTION` parameters are explicitly typed `int` in
CurlFactory.

StreamHandler always provided `null` as the upload progress, because the
progress is not known there. Adjust this to `0` for consistent behavior.
@GrahamCampbell GrahamCampbell merged commit 5da9dac into guzzle:master Oct 7, 2021
23 checks passed
@TimWolla TimWolla deleted the stream-progress-unknown branch Oct 7, 2021
@GrahamCampbell
Copy link
Member

GrahamCampbell commented Oct 18, 2021

6.4.0 has now been released, including this fix. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants