[8.0] Fix Utils::json*() for native \JSON_THROW_ON_ERROR option
#3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user passes the native `\JSON_THROW_ON_ERROR` option, these functions would throw a `\JsonException` instead of the expected `\InvalidArgumentException`.
|
Oh, this only exists as of PHP 7.3. Would you consider it appropriate to drop support for PHP 7.2? It's at 1.8% for Guzzle 7 as per: https://packagist.org/packages/guzzlehttp/guzzle/php-stats#7 |
|
We can consider this for Guzzle 8. AWS and others need Guzzle 7 to retain PHP 7.2 support. We're also still fighting to get people to upgrade from Guzzle 5 and 6, so dropping more PHP versions is just gonna make it harder, or give us two 7.x lines to provide security fixes for. |
GrahamCampbell
changed the title
\JSON_THROW_ON_ERROR option\JSON_THROW_ON_ERROR option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user passes the native
\JSON_THROW_ON_ERRORoption, these functions would throw a\JsonExceptioninstead of the expected\InvalidArgumentException.