Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.9] Improve Accept-Encoding documentation #3215

Merged
merged 3 commits into from
Jul 18, 2024

Commits on Apr 13, 2024

  1. Curl: Improve Accept-Encoding comment

    guzzle@1d46cec
    tried to improve the comment but the new content implies an empty header
    will be sent.
    
    That is not the case. Quoting from <https://curl.se/libcurl/c/CURLOPT_HTTPHEADER.html>:
    
        If you add a header with no content as in 'Accept:'
        (no data on the right side of the colon),
        the internally used header is disabled/removed.
    
    Let’s clarify the point is removing the header to get the default '*'
    <https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept-Encoding#sect2>:
    
        *: Matches any content encoding not already listed in the header.
        This is the default value if the header is not present.
        This directive does not suggest that any algorithm is supported
        but indicates that no preference is expressed.
    
    As that was probably intended by the original change that introduced this:
    guzzle@1a9ad6b
    jtojnar committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    c7b61bf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1a91bce View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Update CurlFactory.php

    GrahamCampbell committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ab1ee16 View commit details
    Browse the repository at this point in the history