This repository has been archived by the owner on Jun 27, 2022. It is now read-only.
Match latest (>= 1.4.3) Doctrine Cache behaviour #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,7 +65,7 @@ | |||
| }, | |||
|
|
|||
| "require-dev": { | |||
| "doctrine/cache": "~1.3", | |||
| "doctrine/cache": "~1.4.3", | |||
There was a problem hiding this comment.
you're now preventing 1.5.x
|
@DavidPrevot this pull request of yours fixes the last failing test on my pull request #77. Would you mind if I just cherry-pick your changes and pull them into my pull request? The only change I would make would be to composer require doctrine/cache ~1.4 as requested above. |
|
Hi, Le 24/03/2016 08:08, Shawn Iwinski a écrit :
Please do! Thanks. Regards David |
siwinski
added a commit
to siwinski/guzzle3
that referenced
this pull request
Mar 24, 2016
|
@DavidPrevot thanks! @DavidPrevot @GrahamCampbell these changes have been cherry-picked into #77 so this pull request may be closed. |
|
Superseded by #77 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: https://github.com/guzzle/guzzle3/issues/67
Bug-Debian: https://bugs.debian.org/804583