-
Notifications
You must be signed in to change notification settings - Fork 93
Update tests to allow for Doctrine Cache >= 1.6.0 internal changes #77
Conversation
If you can fix the broken test, I'll merge this. |
@mtdowling #69 fixes that last test failure. Would you like that full change merged into this pull request? |
@GrahamCampbell should the |
Is this ready to merge? Are there other PRs that need to be merged in tandem? |
@mtdowling I just manually verified that the |
I'm not sure what the HHVM test failure was. Perhaps a fluke? |
Only change from previous passing automation run was 2ddcdd7 which should not have caused the HHVM error. Please re-queue tests. |
Re-running tests now... |
The only differences I see are:
I don't use HHVM and it will take me a while to get this debugged. Perhaps someone else knows what's going on? |
Thanks for the PR, but I'm going to close this since this repo has been EOL for a while now. |
I understand this library is deprecated, but it is still used by several other libraries I need to support. I ran across this issue when updating Doctrine Cache from 1.5.4 to 1.6.0. Since Doctrine Cache changed its' private
data
attribute and theguzzle3
tests bypass scope and use that private attribute directly, this patch only modifies the tests themselves.