Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

Update tests to allow for Doctrine Cache >= 1.6.0 internal changes #77

Closed
wants to merge 5 commits into from

Conversation

siwinski
Copy link

I understand this library is deprecated, but it is still used by several other libraries I need to support. I ran across this issue when updating Doctrine Cache from 1.5.4 to 1.6.0. Since Doctrine Cache changed its' private data attribute and the guzzle3 tests bypass scope and use that private attribute directly, this patch only modifies the tests themselves.

@mtdowling
Copy link
Member

If you can fix the broken test, I'll merge this.

@siwinski
Copy link
Author

@mtdowling #69 fixes that last test failure. Would you like that full change merged into this pull request?

@siwinski
Copy link
Author

@GrahamCampbell should the doctrine/cache dependency really be ~1.4,>=1.4.3 instead of just ~1.4?

@mtdowling
Copy link
Member

Is this ready to merge? Are there other PRs that need to be merged in tandem?

@siwinski
Copy link
Author

@mtdowling I just manually verified that the doctrine/cache dependency does need to be ~1.4,>=1.4.3 instead of just ~1.4 (1.4.0, 1.4.1, and 1.4.2 fail tests). I just updated that dependency with my last commit. After the travis checks run this is ready to merge IMO.

@siwinski
Copy link
Author

I'm not sure what the HHVM test failure was. Perhaps a fluke?

@siwinski
Copy link
Author

Only change from previous passing automation run was 2ddcdd7 which should not have caused the HHVM error. Please re-queue tests.

@mtdowling
Copy link
Member

Re-running tests now...

@siwinski
Copy link
Author

  1. Previous passing HHVM test: https://travis-ci.org/guzzle/guzzle3/jobs/118215651
  2. Then change: 2ddcdd7
  3. Then failing HHVM test: https://travis-ci.org/guzzle/guzzle3/jobs/118303147

The only differences I see are:

  • symfony/event-dispatcher (v2.8.3) => symfony/event-dispatcher (v2.8.4)
  • symfony/class-loader (v2.8.3) => symfony/class-loader (v2.8.4)
  • symfony/yaml (v2.8.3) => symfony/yaml (v2.8.4)

I don't use HHVM and it will take me a while to get this debugged. Perhaps someone else knows what's going on?

@GrahamCampbell
Copy link
Member

Thanks for the PR, but I'm going to close this since this repo has been EOL for a while now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants