Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read/Write detection doesnt work correctly for resources from gzopen #115

Closed
mcfedr opened this issue Aug 27, 2016 · 1 comment
Closed
Milestone

Comments

@mcfedr
Copy link

mcfedr commented Aug 27, 2016

When opening a file with gzopen it is possible to specify some extra options, compression level, etc

When a Stream is created it detects readable/writable checking the mode with $readWriteHash which doesn't have entries for all possible modes, eg 'rb9' or wb2.

This results in the Stream being incorrectly marked as neither readable or writable.

I would be happy to make a pull request, but thinking about the best solution. It would be possible to add all the variations to $readWriteHash, but maybe some string manipulation is better option.

@Tobion
Copy link
Member

Tobion commented Apr 11, 2018

I'd be happy to see a PR with a test. This is related to #183. So if you come up with an easy solution usingg string manipulation, that's fine with me as well.

sagikazarmark added a commit that referenced this issue Dec 7, 2018
@sagikazarmark sagikazarmark added this to the 1.6.0 milestone Dec 7, 2018
sagikazarmark added a commit that referenced this issue Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants