Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factory implementations for PSR-7 related objects.
It adds one external dependency (which becomes stable this week). It provides Factory interfaces.
The idea behind this project is that message construction COULD also be standardized. It's not a requirement, but can be useful in some cases. Actually it is useful in any cases where you allow using any kind of PSR-7 implementation, not just one.
We regularly use it in HTTPlug and any packages which rely on it: FOS HTTP Cache, FXMLRPC, possibly in the future Geocoder too.
We had these interfaces implemented in a custom repository along with factories for Diactoros, but we realized that it would be cool if factories were provided by implementations themselves. In case of Diactoros it is possibly harder, because it already provides some factories which are incompatible with these interfaces. In such cases we have to use bridge packages, like this:
https://github.com/mekras/httplug-diactoros-bridge
However it adds an extra dependency, and somewhat redundancy, as you require a message implementation AND a bridge package for it.
Not sure if it is something that you want to merge, but I thought I would submit it anyway.
/cc @dbu @joelwurtz @mekras