You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Instead of this and to keep core clear of any details of format it would be better to have a method called AddFormat(name string, builder SummaryBuilder) . The correct builder would then be looked up from a map at time of execution. The JSONSummaryBuilder would live in a JSON package inside of the serialisation package and the YAMLSummaryBuilder inside the yaml package.
Currently we have JSON and YAML concerns inside of core:
Instead of this and to keep
core
clear of any details of format it would be better to have a method calledAddFormat(name string, builder SummaryBuilder)
. The correct builder would then be looked up from a map at time of execution. TheJSONSummaryBuilder
would live in a JSON package inside of the serialisation package and theYAMLSummaryBuilder
inside the yaml package.I missed this on the review of #103
The text was updated successfully, but these errors were encountered: