Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary format#89 #103

Merged
merged 11 commits into from
Jan 28, 2017
Merged

Summary format#89 #103

merged 11 commits into from
Jan 28, 2017

Conversation

jamlen
Copy link
Member

@jamlen jamlen commented Jan 25, 2017

closes #89

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 751eeb2 on Summary-format#89 into 4f1412b on develop.

@@ -0,0 +1,29 @@
package core

type MinMaxMeanTotalInt struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call this type Stat or something. If we add StdDev we then have to change the name of the type.

Random bool
Summary bool
SummaryFormat string `json:"summary-format"`
SummaryBuilder core.SummaryBuilder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say a SummaryBuilder takes a configuration as opposed to a Configuration being coupled to a SummaryBuilder.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling c9e81a2 on Summary-format#89 into 4f1412b on develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling c9e81a2 on Summary-format#89 into 4f1412b on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+50.8%) to 50.833% when pulling 428ab9d on Summary-format#89 into 4f1412b on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+52.02%) to 52.016% when pulling b2bc359 on Summary-format#89 into 4f1412b on develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 7b2d895 on Summary-format#89 into 4f1412b on develop.

Copy link
Member

@reaandrew reaandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corcel-report.html.gz
corcel-report.json

Could you remove these from git? Not sure if they came in on this branch or they are from before but best to get shut - didn't notice until now. Could you add them to the .gitignore too ?

Copy link
Member

@reaandrew reaandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. If you could remove those files - it looks ace! 👍

easier. Adding test coverage for yaml PlanBuilder
@jamlen
Copy link
Member Author

jamlen commented Jan 26, 2017

If you look at the files in the PR I am actually already deleting them in this!

@coveralls
Copy link

Coverage Status

Coverage increased (+51.6%) to 51.584% when pulling b2b60f8 on Summary-format#89 into 4f1412b on develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 5523e14 on Summary-format#89 into 4f1412b on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+53.3%) to 53.299% when pulling 7a006d3 on Summary-format#89 into 4f1412b on develop.

@reaandrew reaandrew merged commit e71d64b into develop Jan 28, 2017
@reaandrew reaandrew deleted the Summary-format#89 branch January 28, 2017 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow summary to output in machine readable form
3 participants