Need to create .cvmfscatalog file #4619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spxiwh
added
the
v23_release_branch
GarethCabournDavies
approved these changes
Feb 5, 2024
spxiwh
added a commit
to spxiwh/pycbc
that referenced
this pull request
Feb 9, 2024
spxiwh
added a commit
that referenced
this pull request
Feb 9, 2024
* Need to create .cvmfscatalog file (#4619) * Workflow changes needed to manage offline gracedb upload prep (#4535) * Workflow changes needed to manage preparation of offline gracedb upload files * fix change removed after rebase * Allow waveforms to not be given * IH comments * Update setup.py --------- Co-authored-by: Gareth S Cabourn Davies <gareth.cabourndavies@ligo.org>
spxiwh
removed
the
v23_release_branch
bhooshan-gadre
pushed a commit
to bhooshan-gadre/pycbc
that referenced
this pull request
Mar 4, 2024
lpathak97
pushed a commit
to lpathak97/pycbc
that referenced
this pull request
Mar 13, 2024
acorreia61201
pushed a commit
to acorreia61201/pycbc
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been some restructuring in the LVK CVMFS repo to split into "nested catalogs" to avoid the error:
This LVK change broke our deployment code, but the fix is minor. Following discussion with Stuart/Duncan within LVK (https://git.ligo.org/computing/helpdesk/-/issues/4886) this seems to be what is required.
I've tested that creating this file allows us to deploy the 2.3.4 release. There's the normal caveat with patches on the deployment code that we can only deploy new code on an actual release, so this code will only get properly tested when the next release is made ... I can always fix this if something isn't quite right.