-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc. formatting improvements for gwdetchar-omega #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 308
💛 - Coveralls |
duncanmmacleod
requested changes
Sep 14, 2018
@duncanmmacleod, I've pushed a few commits that address your review comments. I also reorganized the layout for each channel so that the table of loudest-tile properties is horizontal at the top, aligned with the toggle buttons, and a row of three plots is saved at the bottom. The examples for H1 and L1 linked to above have been updated with these changes. |
alurban
force-pushed
the
misc-formatting
branch
4 times, most recently
from
September 18, 2018 01:06
db8d849
to
793410d
Compare
…ns show up nicely formatted on one line
…h a slight tradeoff in whitespace
…every channel block, and once again at the very end
alurban
force-pushed
the
misc-formatting
branch
from
September 19, 2018 03:47
793410d
to
10058c3
Compare
duncanmmacleod
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@duncanmmacleod, this PR contains a few formatting enhancements for
gwdetchar-omega
output pages, including:container
width and adapt its size for different screensExamples may be found here (requires
LIGO.ORG
credentials):This fixes #122.