Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. formatting improvements for gwdetchar-omega #123

Merged
merged 10 commits into from
Sep 25, 2018

Conversation

alurban
Copy link
Member

@alurban alurban commented Sep 14, 2018

@duncanmmacleod, this PR contains a few formatting enhancements for gwdetchar-omega output pages, including:

  • Restoring IFO-specific context highlighting in plot toggle buttons
  • Expand container width and adapt its size for different screens
  • Reorganizing the channel information display so that the channel name is on its own line, plot toggle buttons are flushed right on the same line as the loudest-tile table (which is now horizontal), and up to three plots are shown on a single line beneath the table
  • De-bolden section headings (which will need to be done more gracefully once gwdetchar-omega should use bootstrap-ligo for CSS helpers #90 is addressed)
  • Update the output page after every channel has been analyzed, as well as after every channel block, and once again at the very end

Examples may be found here (requires LIGO.ORG credentials):

IFO Scan time Results
Hanford 1187020580.44 results
Livingston 1172489783.070 results
GEO 1186970418.0 results

This fixes #122.

@coveralls
Copy link

coveralls commented Sep 14, 2018

Pull Request Test Coverage Report for Build 308

  • 0 of 30 (0.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 40.263%

Changes Missing Coverage Covered Lines Changed/Added Lines %
gwdetchar/omega/plot.py 0 2 0.0%
gwdetchar/omega/html.py 0 28 0.0%
Files with Coverage Reduction New Missed Lines %
gwdetchar/omega/plot.py 1 0.0%
gwdetchar/omega/html.py 3 0.0%
Totals Coverage Status
Change from base Build 305: -0.2%
Covered Lines: 428
Relevant Lines: 1063

💛 - Coveralls

gwdetchar/omega/html.py Outdated Show resolved Hide resolved
gwdetchar/omega/html.py Outdated Show resolved Hide resolved
@alurban
Copy link
Member Author

alurban commented Sep 15, 2018

@duncanmmacleod, I've pushed a few commits that address your review comments. I also reorganized the layout for each channel so that the table of loudest-tile properties is horizontal at the top, aligned with the toggle buttons, and a row of three plots is saved at the bottom. The examples for H1 and L1 linked to above have been updated with these changes.

@duncanmmacleod duncanmmacleod merged commit 79d2657 into gwdetchar:master Sep 25, 2018
@alurban alurban deleted the misc-formatting branch September 25, 2018 14:10
@alurban alurban added this to In progress in Stabilize gwdetchar-omega via automation Sep 27, 2018
@alurban alurban moved this from In progress to Done in Stabilize gwdetchar-omega Sep 27, 2018
@alurban alurban added this to Done in O3 Omega Scans Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Misc. gwdetchar-omega formatting issues
3 participants