Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update submodules before installing #240

Merged
merged 2 commits into from
Mar 4, 2019
Merged

Update submodules before installing #240

merged 2 commits into from
Mar 4, 2019

Conversation

alurban
Copy link
Member

@alurban alurban commented Mar 4, 2019 •
edited
Loading

This fixes a couple of issues with the conda build of gwdetchar-0.2.0:

  • Use mock functions instead of tmp directory in unit tests for gwdetchar.io.datafind
  • Make sure the bootstrap-ligo submodule is populated before building

@alurban alurban self-assigned this Mar 4, 2019
@coveralls
Copy link

coveralls commented Mar 4, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 91.81% when pulling d4e7e2d on alurban:fix-build into 68bbe80 on gwdetchar:master.

duncanmmacleod
duncanmmacleod approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@duncanmmacleod duncanmmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alurban alurban merged commit d3bb4b7 into gwdetchar:master Mar 4, 2019
@alurban alurban deleted the fix-build branch March 4, 2019 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanmmacleod duncanmmacleod duncanmmacleod approved these changes

Assignees

@alurban alurban

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alurban @coveralls @duncanmmacleod