Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a common utility to render HTML 'about' sections #261

Merged
merged 6 commits into from
Mar 12, 2019
Merged

Use a common utility to render HTML 'about' sections #261

merged 6 commits into from
Mar 12, 2019

Conversation

alurban
Copy link
Member

@alurban alurban commented Mar 11, 2019 •
edited
Loading

This PR introduces a common utility (under gwdetchar.io.html) for rendering 'about' sections in HTML. The new utility is invoked by the overflow, software saturations, scattering, slow correlation, and LASSO correlation tools.

This PR also includes a unit test, and pedantically re-orders function definitions in gwdetchar.io.html.

Test output is available here:

Tool Output
gwdetchar-lasso-correlation Link
gwdetchar-overflow Link
gwdetchar-software-saturations Link
gwdetchar-scattering Link

cc @duncanmmacleod

@alurban alurban added this to the 0.3.0 milestone Mar 11, 2019
@coveralls
Copy link

coveralls commented Mar 11, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 95.546% when pulling 0c65762 on alurban:move-html into 592ebd2 on gwdetchar:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 95.549% when pulling e4f854b on alurban:move-html into 976bf1d on gwdetchar:master.

@alurban alurban changed the title WIP: Use a common utility to render HTML 'about' sections Use a common utility to render HTML 'about' sections Mar 11, 2019
duncanmmacleod
duncanmmacleod approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@duncanmmacleod duncanmmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alurban alurban merged commit 2a216cf into gwdetchar:master Mar 12, 2019
@alurban alurban deleted the move-html branch March 12, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanmmacleod duncanmmacleod duncanmmacleod approved these changes

Assignees
No one assigned
Labels
enhancement html lasso overflow scattering software saturations
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alurban @coveralls @duncanmmacleod