Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close button css is different than in the example #20

Closed
SamGeens opened this issue Sep 24, 2023 · 2 comments
Closed

Close button css is different than in the example #20

SamGeens opened this issue Sep 24, 2023 · 2 comments
Assignees
@gwinnem
Labels
bug Something isn't working

Comments

@SamGeens
Copy link

Expected Behavior

Have a nice close button like in the example docs.

image

Current Behavior

When I use the exact same code the close button doesn't look the same and the text 'close' is displayed.
image

Steps to Reproduce

The behavior can be seen in this codesandbox.
@gwinnem gwinnem added the bug Something isn't working label Sep 27, 2023
@gwinnem gwinnem self-assigned this Oct 2, 2023
@gwinnem
Copy link
Owner

gwinnem commented Oct 2, 2023

Removed the span which was displaying the Close text.
Update will come in v1.2.3

@gwinnem gwinnem closed this as completed Oct 2, 2023
gwinnem added a commit that referenced this issue Oct 21, 2023
@gwinnem
Fix for Close button css is different than in the example #20
9cc14d6
@SamGeens
Copy link
Author

Hi, I updated the plugin to version 1.2.4 but for some reason the close text is still being displayed.

Steps to Reproduce

The behavior can be seen in this codesandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gwinnem gwinnem

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gwinnem @SamGeens