Remove * imports from __init__.py #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the main things I did here was remove all the of
from x import *from the init.py files. Trying to run `bin/inference_on_gwnr_tools' I was getting a really obscure error related to importing matplotlib in a source file that wasn't used in that file, but importing matplotlib worked elsewhere. I think it's because the 'import *' in the init files means that the entire codebase becomes coupled, and import errors in unrelated parts of the code prop up whenever it's used.Because of that I had to make sure that the correct imports were used in every file, I tried to do this by grepping pylint but I may have missed some errors.
I also relaxed the stringent requirements, I'm not sure what packages should have their versions restricted but some might need it.