Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeSeries.read does not respect gap='raise' if gap is at the start or end of the requested segment #1211

Closed
lpsinger opened this issue Feb 24, 2020 · 2 comments · Fixed by #1215
Closed

TimeSeries.read does not respect gap='raise' if gap is at the start or end of the requested segment #1211

lpsinger opened this issue Feb 24, 2020 · 2 comments · Fixed by #1215
Assignees
@duncanmmacleod

Comments

@lpsinger
Copy link
Contributor

See https://git.ligo.org/emfollow/gwcelery/issues/310.
@duncanmmacleod
Copy link
Member

@lpsinger, can you please post a minimal snippet of code to reproduce the failure?

@lpsinger
Copy link
Contributor Author 

>>> from pkg_resources import resource_filename
>>> from gwpy.timeseries import TimeSeries
>>> TimeSeries.read(
... resource_filename('gwpy.testing', 'data/HLV-HW100916-968654552-1.gwf'),
... 'L1:LDAS-STRAIN', start=968654552, end=968654554, gap='raise', pad=42.0)
<TimeSeries([-2.83959930e-17, -2.89436792e-17, -2.76748673e-17,
             ...,  4.20000000e+01,  4.20000000e+01,
              4.20000000e+01]
            unit=Unit("strain"),
            t0=<Quantity 9.68654552e+08 s>,
            dt=<Quantity 6.10351562e-05 s>,
            name='L1:LDAS-STRAIN',
            channel=<Channel("L1:LDAS-STRAIN", 16384.0 Hz) at 0x7f69f754a128>)>

@duncanmmacleod duncanmmacleod self-assigned this Feb 27, 2020
duncanmmacleod added a commit to duncanmmacleod/gwpy that referenced this issue Feb 27, 2020
@duncanmmacleod
gwpy.timeseries: raise ValueError in TimeSeries.read
2dc4fba 
if gap='raise' is given and the file(s) return a proper subset of the request
fixes gwpy#1211
@duncanmmacleod duncanmmacleod mentioned this issue Feb 27, 2020
Merged
duncanmmacleod added a commit to duncanmmacleod/gwpy that referenced this issue Apr 16, 2020
@duncanmmacleod
gwpy.timeseries: raise ValueError in TimeSeries.read
090dd99 
if gap='raise' is given and the file(s) return a proper subset of the request
fixes gwpy#1211
duncanmmacleod added a commit to duncanmmacleod/gwpy that referenced this issue May 5, 2020
@duncanmmacleod
gwpy.timeseries: raise ValueError in TimeSeries.read
00b9b33 
if gap='raise' is given and the file(s) return a proper subset of the request
fixes gwpy#1211
duncanmmacleod added a commit to duncanmmacleod/gwpy that referenced this issue Jul 2, 2020
@duncanmmacleod
gwpy.timeseries: raise ValueError in TimeSeries.read
a2a5f95 
if gap='raise' is given and the file(s) return a proper subset of the request
fixes gwpy#1211
duncanmmacleod added a commit to duncanmmacleod/gwpy that referenced this issue Jul 2, 2020
@duncanmmacleod
gwpy.timeseries: raise ValueError in TimeSeries.read
774f177 
if gap='raise' is given and the file(s) return a proper subset of the request
fixes gwpy#1211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duncanmmacleod duncanmmacleod

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Raise ValueError in TimeSeries.read if file(s) return a proper subset of request duncanmmacleod/gwpy
2 participants
@lpsinger @duncanmmacleod