Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests for frameCPP errors and fixed a bug #1056

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Added tests for frameCPP errors and fixed a bug #1056

merged 1 commit into from
Feb 25, 2019

Conversation

duncanmmacleod
Copy link
Member

This PR adds a test_read_write_gwf_errors test method that exposed a failure, and corrects said failure in error reporting.

@duncanmmacleod
gwpy.timeseries: added tests for frameCPP errors
9394e5e 
and fixed bugs in error reporting
@coveralls
Copy link

coveralls commented Feb 25, 2019 •
edited

Coverage Status

Coverage increased (+0.01%) to 91.149% when pulling 9394e5e on duncanmmacleod:gwf-errors into 656bdc9 on gwpy:develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 91.086% when pulling 9394e5e on duncanmmacleod:gwf-errors into 656bdc9 on gwpy:develop.

@duncanmmacleod duncanmmacleod requested a review from a team February 25, 2019 14:39
@duncanmmacleod duncanmmacleod self-assigned this Feb 25, 2019
@duncanmmacleod duncanmmacleod added gwpy.timeseries Issues/changes related to the gwpy.timeseries module api:patch Proposed changes introduce no changes to the API or bug fixes only dep:frameCPP Issues/changes related to frameCPP compatibility labels Feb 25, 2019
@duncanmmacleod duncanmmacleod added this to the 0.14.0 milestone Feb 25, 2019
alurban
alurban approved these changes Feb 25, 2019
View reviewed changes
Copy link

@alurban alurban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @duncanmmacleod

@duncanmmacleod duncanmmacleod merged commit 83e1429 into gwpy:develop Feb 25, 2019
@duncanmmacleod duncanmmacleod deleted the gwf-errors branch February 25, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alurban alurban alurban approved these changes

Assignees

@duncanmmacleod duncanmmacleod

Labels
api:patch Proposed changes introduce no changes to the API or bug fixes only dep:frameCPP Issues/changes related to frameCPP compatibility gwpy.timeseries Issues/changes related to the gwpy.timeseries module
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@duncanmmacleod @coveralls @alurban