Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all metadata out of setup.cfg into pyproject.toml #1547

Merged
merged 3 commits into from Nov 3, 2022

Conversation

duncanmmacleod
Copy link
Member

This PR migrates all package metadata into pyproject.toml now that setuptools supports it. This way everything is in pyproject.toml, rather than being split into setup.cfg as well.

This should have no practical impact on the package.

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #1547 (5330b1d) into main (5330b1d) will not change coverage.
The diff coverage is n/a.

❗ Current head 5330b1d differs from pull request most recent head 0c59b32. Consider uploading reports for the commit 0c59b32 to get more accurate results

@@          Coverage Diff          @@
##            main   #1547   +/-   ##
=====================================
  Coverage   94.5%   94.5%           
=====================================
  Files        228     228           
  Lines      16927   16927           
=====================================
  Hits       16007   16007           
  Misses       920     920           
Flag Coverage Δ
Linux 94.5% <0.0%> (ø)
Windows 84.3% <0.0%> (ø)
macOS 93.8% <0.0%> (ø)
python3.10 94.4% <0.0%> (ø)
python3.7 94.3% <0.0%> (ø)
python3.8 94.4% <0.0%> (ø)
python3.9 94.4% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

so that there is one build file to rule them all, also move to 'standard' TOML style based on the examples given in the toml-lang/toml README
one less reference to a specific build system, which we might want to change in the future
install it into its own environment, separate from everything else
@duncanmmacleod duncanmmacleod self-assigned this Nov 3, 2022
@duncanmmacleod duncanmmacleod requested a review from a team November 3, 2022 10:01
@duncanmmacleod duncanmmacleod added this to the 3.0.1 milestone Nov 3, 2022
@duncanmmacleod duncanmmacleod added build:general api:patch Proposed changes introduce no changes to the API or bug fixes only labels Nov 3, 2022
Copy link
Contributor

@areeda areeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duncanmmacleod duncanmmacleod merged commit b83ebe3 into gwpy:main Nov 3, 2022
@duncanmmacleod duncanmmacleod deleted the meta-all-pyproject.toml branch November 3, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api:patch Proposed changes introduce no changes to the API or bug fixes only build:general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants