Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence some NDS2 host warnings #930

Merged
merged 2 commits into from Oct 19, 2018
Merged

Silence some NDS2 host warnings #930

merged 2 commits into from Oct 19, 2018

Conversation

duncanmmacleod
Copy link
Member

This PR silences the no default host found for ifo 'V1' style warnings when you try to dynamically get (fetch) data for a non-LIGO interferometer, as long as the NDSSERVER variable is set (meaning the user/admin has opted into selecting the default host for themselves).

Fixes #816.

@duncanmmacleod
gwpy.io: silence some NDS2 host warnings
0a1c7dc 
by default GWpy will _always_ emit a warning whenever you try to dynamically work out the NDS2 host for a non-LIGO interferometer. This commit changes the default behaviour such that if `NDSSERVER` is set (or similar), then a warning will not be emitted.
@pep8speaks
Copy link

Hello @duncanmmacleod! Thanks for submitting the PR.

@coveralls
Copy link

coveralls commented Oct 17, 2018 •
edited

Coverage Status

Coverage increased (+0.01%) to 91.74% when pulling 86a339d on duncanmmacleod:nds2-default-host-warning into dca49aa on gwpy:develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.9%) to 85.832% when pulling 0a1c7dc on duncanmmacleod:nds2-default-host-warning into dca49aa on gwpy:develop.

@duncanmmacleod
Copy link
Member Author

@areeda, I think this fixes your issue, can you review please?

@duncanmmacleod duncanmmacleod self-assigned this Oct 17, 2018
@duncanmmacleod duncanmmacleod added gwpy.io Issues/changes related to the gwpy.io module dep:nds2 api:patch Proposed changes introduce no changes to the API or bug fixes only labels Oct 17, 2018
@duncanmmacleod duncanmmacleod added this to the 0.12.2 milestone Oct 17, 2018
areeda
areeda approved these changes Oct 19, 2018
View reviewed changes
Copy link
Contributor

@areeda areeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gives us a good work around for the warning.
I wonder if we would benefit from having defayult servers for V1 = nds.ligo.caltech.edu and X1 = nds40.ligo.caltech.edu since those are the only nds2 servers with data from those IFOs.

@duncanmmacleod duncanmmacleod merged commit 25ffaa6 into gwpy:develop Oct 19, 2018
@duncanmmacleod duncanmmacleod deleted the nds2-default-host-warning branch October 19, 2018 03:56
@duncanmmacleod duncanmmacleod modified the milestones: 0.12.2, 0.12.3 Oct 24, 2018
@duncanmmacleod duncanmmacleod modified the milestones: 0.12.3, 0.13.0 Feb 5, 2019
@duncanmmacleod duncanmmacleod restored the nds2-default-host-warning branch March 16, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@areeda areeda areeda approved these changes

Assignees

@duncanmmacleod duncanmmacleod

Labels
api:patch Proposed changes introduce no changes to the API or bug fixes only dep:nds2 gwpy.io Issues/changes related to the gwpy.io module
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@duncanmmacleod @pep8speaks @coveralls @areeda