Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No CodeServer launched after Tomcat start #65

Closed
dodgex opened this issue May 15, 2015 · 25 comments
Closed

No CodeServer launched after Tomcat start #65

dodgex opened this issue May 15, 2015 · 25 comments

Comments

@dodgex
Copy link

dodgex commented May 15, 2015

Hello there!

I just wanted to test this plugin and followed the steps from this video. But when i started the Tomcat from eclipse, there where no superdev code server started. the only difference i could spot is that i'm using tomcat 7 instead of 8.

i followed the steps from the video and rechecked everything multiple times, even when i manually create a run configuration for the code server and name it gwt-my-context-name (assuming it tries to find a run configuration with gwt- prefix) it does not start it.

when i start both manually it works like a charm, but it would be nice to start both together. :)

any idea what i might have done wrong?

@dodgex
Copy link
Author

dodgex commented May 15, 2015

for some reason the plugin just decided to start the code server. i have absolutely no idea what might have changed.

@dodgex dodgex closed this as completed May 15, 2015
@branflake2267
Copy link
Contributor

I think this issue is related to another issue on ubuntu. I found the issue and working on it. The GWT Nature isn't getting turned on b/c it's using the facet. At least thats one of the issues I found and fixed last night. I'm testing it tonight, but this is legit. .

@branflake2267 branflake2267 reopened this May 15, 2015
@branflake2267 branflake2267 added this to the GWT Plugin 1.0 milestone May 15, 2015
@branflake2267
Copy link
Contributor

Which OS are yo using?

@dodgex
Copy link
Author

dodgex commented May 15, 2015

Eclipse 4.4.2 on Windows Server 2008 R2 Standard x64

@branflake2267
Copy link
Contributor

Thank you for reporting.

@branflake2267
Copy link
Contributor

If you have time, could you confirm something? I have a feeling it says this on your launcher. Project does not use GWT or GAE

Go to the debug configurations, find the GWT SDM Code Server launcher and see if it says
screen shot 2015-05-15 at 7 46 35 am

Might have to add the main type, CodeServer to see that.

@dodgex
Copy link
Author

dodgex commented May 15, 2015

it does not show the message. and as i mentioned, the plugin started to work correctly at some point after restarting both the codeserver and tomcat some times (maybe i even restarted eclipse between that but i'm not sure about that).

@branflake2267
Copy link
Contributor

oh ok, sounds good. The nature got turned on, on another route then.

@branflake2267
Copy link
Contributor

Can you update the plugin and try it again? Delete the code launcher and then start the server which will create a new code launcher.

@dodgex
Copy link
Author

dodgex commented May 20, 2015

it creates a launch config, but that does not work due to the src/main/resources issue.

so i think this one is ok now.

@dodgex
Copy link
Author

dodgex commented May 20, 2015

but: it seems to only work if i start the tomcat from the servers tab. when using the the launch configuration via the run icon in the toolbar it does not start the CodeServer.

and also: is there a way to restart the tomcat, without restarting the CodeServer? although we are currently evaluating jrebel there will still be some situations where we would need to restart the server part

Thanks :)

@branflake2267
Copy link
Contributor

There is a way to restart the server without restarting the code server. By default it restarts the code server. This can be turned off in the project properties menu > filter facet > goto gwt facet, disable the sync.

@dodgex
Copy link
Author

dodgex commented May 21, 2015

The problem is, that option does not start the CodeServer when starting the tomcat.

It might be a first world & lazy dev problem, but imo it would be nice to start them together but be able to restart the tomcat without the code server. (maybe even stop both when the code server is stopped? - not sure about this one).

feel free to decide about this if you might think that is a good idea and the need effort is reasonable. if you think it is not worth implementing, i'm ok with this... as i said: first world problem. hitting play twice shouldnt hurt that much . although the feature to start both is one of the things that make this plugin better than the original one. ;)

@dodgex
Copy link
Author

dodgex commented May 21, 2015

Update: with this option turned off, it does not start the CodeServer together with tomcat, but it still stops it when stopping the tomcat :/

@branflake2267
Copy link
Contributor

oh yeah, that is a bug. Nice find.

@branflake2267
Copy link
Contributor

#71 - fix on its way, waiting for build server...

@dodgex
Copy link
Author

dodgex commented Jul 30, 2015

i just realized that this issue is still open. at least with the latest version (just updated all of my plugins) it starts both now when starting the tomcat.

but still it kills the SDM when i stop/restart the tomcat. as mentioned here it might be a nice feature to be able to restart the tomcat without restarting the SDM.

@dodgex
Copy link
Author

dodgex commented Jul 30, 2015

and sadly it seems that your fix in #71 is broken :/

It still kills the SDM when sync is disabled
image

@dodgex
Copy link
Author

dodgex commented Jul 30, 2015

eclipse 4.4.2
gwtplugin version: 0.0.0.201507300611

@branflake2267
Copy link
Contributor

I added something to turn off the sync. Would this work for you. Goto project properties then to gwt facet settings.

screen shot 2015-07-30 at 7 47 10 am

@dodgex
Copy link
Author

dodgex commented Jul 30, 2015

I know this option. And even if this is unchecked it kills the SDM.

@branflake2267
Copy link
Contributor

Gotcha, something to fix then.

@dodgex
Copy link
Author

dodgex commented Jul 31, 2015

maybe while you are on it, you could add an option to start both together, but allow to restart the tomcat without restarting the SDM? or should i open a new issue for that? :)

@branflake2267
Copy link
Contributor

Could you create a new issue for that request?

@branflake2267
Copy link
Contributor

I've got a fix for killing sdm on server termination coming...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants