Skip to content
This repository has been archived by the owner on Aug 5, 2019. It is now read-only.

squid:S1118 - Utility classes should not have public constructors #523

Merged
merged 1 commit into from
Feb 1, 2016
Merged

squid:S1118 - Utility classes should not have public constructors #523

merged 1 commit into from
Feb 1, 2016

Conversation

m-ezzat
Copy link

@m-ezzat m-ezzat commented Jan 13, 2016

This pull request is focused on resolving occurrences of Sonar rule squid:S1118 - Utility classes should not have public constructors
You can find more information about the issue here:
https://dev.eclipse.org/sonar/coding_rules#q=squid:S1118
Please let me know if you have any questions.
M-Ezzat

@caarlos0
Copy link
Contributor

@m-ezzat looks like build is failing here..

@m-ezzat
Copy link
Author

m-ezzat commented Jan 13, 2016

I'll check it

@m-ezzat
Copy link
Author

m-ezzat commented Jan 14, 2016

It seems that those classes are used using reflection, and it wasn't obvious using mvn clean install, unlike using clean compile gwt:compile -Pshowcase, it should work correctly, now. Thanks!

caarlos0 added a commit that referenced this pull request Feb 1, 2016
…d-not-have-public-constructors-fix1

squid:S1118 - Utility classes should not have public constructors
@caarlos0 caarlos0 merged commit 8a67bda into gwtbootstrap:master Feb 1, 2016
@caarlos0
Copy link
Contributor

caarlos0 commented Feb 1, 2016

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants