Skip to content
This repository has been archived by the owner on Nov 15, 2019. It is now read-only.

Input should have a convenience get/set for value #27

Closed
gslender opened this issue Dec 24, 2013 · 5 comments
Closed

Input should have a convenience get/set for value #27

gslender opened this issue Dec 24, 2013 · 5 comments

Comments

@gslender
Copy link
Contributor

Input should have a convenience get/set for value
@gslender
Copy link
Contributor Author

public String getValue() {
return this.getElement().getAttribute("value");
}

@gslender
Copy link
Contributor Author

Sorry, this might have to be...

public final native String getValue() /-{
return this.value;
}-/;

@svenjacobs
Copy link
Contributor

Methods should be named getFormValue() and setFormValue() to not be confused with GWT's HasValue interface. See HasFormValue.

@gslender gslender mentioned this issue Dec 27, 2013
Closed
@gslender
Copy link
Contributor Author

Shouldn't they have both HasFormValuea and HasValue - just like AbstractLabelButton ??

@gslender
Copy link
Contributor Author

Fixed in latest pull request

svenjacobs added a commit that referenced this issue Dec 28, 2013
@svenjacobs
Merge pull request #31 from gslender/master
d9f3559 
Fixes for issues #27 & #29 (try #2)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svenjacobs @gslender