Update StoryRecorder.java #9808
Conversation
| @@ -351,7 +348,9 @@ private void recordStory(SourceInfo info, int fragment, int length, Range range) | |||
| theStory = new StoryImpl(storyCache.get(info), length); | |||
| } | |||
|
|
|||
| emitStory(theStory, range); | |||
| if (range.getStart() < js[curHighestFragment].length()) { | |||
There was a problem hiding this comment.
the check start < length was added outside of emitStory, check that end <= length was added inside that method -- maybe both checks should be in one place -- inside emitStory.
There was a problem hiding this comment.
I do not think so.
It seems that the value of the end of range property is wrong.
The call to emitStory must be kept to get the description of the story.
|
With the patch applied I was able to verify that there are no more exceptions in console and |
|
@DRAWSVG This hasn't been merged yet, I closed the other as it was incomplete compared to this. This pull request is waiting for your reply or update in response to zbynek's comment at #9808 (comment). Unless you are abandoning this change, please reopen it. |
|
So you can merge it |
|
Please take a look at #9808 (comment) to see if it makes sense to either make the suggested change, or reply to explain why we should skip that. |
Fixes #9635
Fixes #9602
Fixes #9804