Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StackEmptyException in StoryRecorder.java #9635

Closed
afrische opened this issue Oct 22, 2018 · 2 comments · Fixed by #9808
Closed

StackEmptyException in StoryRecorder.java #9635

afrische opened this issue Oct 22, 2018 · 2 comments · Fixed by #9808
Assignees
Milestone

Comments

@afrische
Copy link

Gwt 2.8.2

Description

prevent StackEmptyException in StoryRecorder.java

[INFO] java.util.EmptyStackException
[INFO] at java.util.Stack.peek(Stack.java:102)
[INFO] at com.google.gwt.core.ext.soyc.impl.StoryRecorder.analyzeFragment(StoryRecorder.java:179)
[INFO] at com.google.gwt.core.ext.soyc.impl.StoryRecorder.recordStoriesImpl(StoryRecorder.java:132)
[INFO] at com.google.gwt.core.ext.soyc.impl.StoryRecorder.recordStories(StoryRecorder.java:73)
[INFO] at com.google.gwt.dev.jjs.JavaToJavaScriptCompiler.makeSoycArtifacts(JavaToJavaScriptCompiler.java:843)
[INFO] at com.google.gwt.dev.jjs.JavaToJavaScriptCompiler.addSoycArtifacts(JavaToJavaScriptCompiler.java:710)
[INFO] at com.google.gwt.dev.jjs.JavaToJavaScriptCompiler.addSyntheticArtifacts(JavaToJavaScriptCompiler.java:731)
[INFO] at com.google.gwt.dev.jjs.JavaToJavaScriptCompiler.compilePermutation(JavaToJavaScriptCompiler.java:454)
[INFO] at com.google.gwt.dev.jjs.JavaToJavaScriptCompiler.compilePermutation(JavaToJavaScriptCompiler.java:272)
[INFO] at com.google.gwt.dev.CompilePerms.compile(CompilePerms.java:198)
[INFO] at com.google.gwt.dev.ThreadedPermutationWorkerFactory$ThreadedPermutationWorker.compile(ThreadedPermutationWorkerFactory.java:50)
[INFO] at com.google.gwt.dev.PermutationWorkerFactory$Manager$WorkerThread.run(PermutationWorkerFactory.java:74)

Steps to reproduce

if nested contexts are empty?
(project is proprietary unfortunately)

Links to further discussions

https://gitter.im/gwtproject/gwt?at=5bc5f887e65a634336ea02d3

99ddc28

@afrische
Copy link
Author

afrische commented Dec 18, 2018

on line 304 of the StoryRecorder there is another peek into the dependencyScope which needs to be checked.
With these two changes, the compile finishes again without errors.

@niloc132
Copy link
Contributor

See also #9602

@niloc132 niloc132 added this to the 2.9 milestone Jan 30, 2019
@niloc132 niloc132 self-assigned this Jan 30, 2019
@niloc132 niloc132 modified the milestones: 2.9, 2.11 Jun 9, 2022
niloc132 pushed a commit that referenced this issue Apr 8, 2023
Wraps a few sections of StoryRecorder to ensure that the stack can
never be empty when it is being read.

Fixes #9635
Fixes #9602
Fixes #9804
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants