Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve firebase functions #205

Merged
merged 6 commits into from
Feb 2, 2019
Merged

Improve firebase functions #205

merged 6 commits into from
Feb 2, 2019

Conversation

Claudio5
Copy link
Member

This PR adds/corrects:

  • Solves the extra time after the timer hits 0 in drawing phase.
  • All firebase promises are now returned which could avoid timeouts (connections errors) when multiple (real) users are connected.

@Claudio5 Claudio5 closed this Jan 1, 2019
@Claudio5 Claudio5 reopened this Jan 1, 2019
@Claudio5 Claudio5 closed this Jan 2, 2019
@Claudio5 Claudio5 reopened this Jan 2, 2019
@Claudio5 Claudio5 closed this Jan 21, 2019
@Claudio5 Claudio5 reopened this Jan 21, 2019
@Claudio5 Claudio5 merged commit 9ade63e into master Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gondolav Gondolav Gondolav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Claudio5 @Gondolav