Switch to mmap implementaion from nix package #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 7, 2019 16:34
The mmap crate is unmaintained and depends on libc that has broken mmap call on 32-bit ARM. Switch to nix::sys::mman::mmap interface. This change breaks API compatibility, since we return `*mut c_void` instead of `mmap::MemoryMap`.
|
Many thanks for submitting this! Do you want me to release this as a new version on crates.io? |
|
Released as 0.2.0 |
Hello! Thanks for the merge. |
|
No major release is requires since we are in major version 0. (From Semver: "Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.") |
|
I must have missed that. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mmap crate is unmantained and depends on libc that has broken mmap call on
32-bit ARM. Switch to nix::sys::mman::mmap interface.
This change breaks API compatibility, since we return
*mut c_voidinstead ofmmap::MemoryMap.