Skip to content

Commit

Permalink
Removing an experimental feature (ampproject#13076)
Browse files Browse the repository at this point in the history
  • Loading branch information
aghassemi authored and gzgogo committed Feb 14, 2018
1 parent 8b48793 commit 7c30781
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 71 deletions.
10 changes: 10 additions & 0 deletions build-system/amp.extern.js
Original file line number Diff line number Diff line change
Expand Up @@ -425,3 +425,13 @@ var rtcResponseDef;
* @type {!function(string):?}
*/
AMP.require;

/**
* TransitionDef function that accepts normtime, typically between 0 and 1 and
* performs an arbitrary animation action. Notice that sometimes normtime can
* dip above 1 or below 0. This is an acceptable case for some curves. The
* second argument is a boolean value that equals "true" for the completed
* transition and "false" for ongoing.
* @typedef {function(number, boolean):?|function(number):?}
*/
var TransitionDef;
30 changes: 0 additions & 30 deletions build-system/amp.nti.extern.js

This file was deleted.

27 changes: 0 additions & 27 deletions build-system/amp.oti.extern.js

This file was deleted.

14 changes: 0 additions & 14 deletions build-system/tasks/compile.js
Original file line number Diff line number Diff line change
Expand Up @@ -311,20 +311,6 @@ function compile(entryModuleFilenames, outputDir,
'globalThis');
compilerOptions.compilerFlags.conformance_configs =
'build-system/conformance-config.textproto';

// TODO(aghassemi): Remove when NTI is the default.
if (argv.nti) {
compilerOptions.compilerFlags.new_type_inf = true;
compilerOptions.compilerFlags.jscomp_off.push(
'newCheckTypesExtraChecks');
compilerOptions.compilerFlags.externs.push(
'build-system/amp.nti.extern.js'
);
} else {
compilerOptions.compilerFlags.externs.push(
'build-system/amp.oti.extern.js'
);
}
}
if (argv.pseudo_names) {
compilerOptions.compilerFlags.define.push('PSEUDO_NAMES=true');
Expand Down

0 comments on commit 7c30781

Please sign in to comment.