Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/specification has 40 passed/41(?) assertions passing. Fix at least 1 failing assertions in specification/test_unit_crud.js #249

Closed
Tracked by #216
Connoropolous opened this issue Apr 12, 2022 · 2 comments
Closed
Tracked by #216

test/specification has 40 passed/41(?) assertions passing. Fix at least 1 failing assertions in specification/test_unit_crud.js #249

Connoropolous opened this issue Apr 12, 2022 · 2 comments
Assignees
@Connoropolous
Labels
bug Something isn't working test-writing Issues related to unit or integration tests

Comments

@Connoropolous
Copy link
Contributor

Connoropolous commented Apr 12, 2022 •
edited
Loading 

cd test
WASM_LOG=debug RUST_LOG=error RUST_BACKTRACE=1 npx tape specification/test_unit_crud.js

40 passed
1 failed
@Connoropolous Connoropolous mentioned this issue Apr 12, 2022
Closed
15 tasks
@Connoropolous Connoropolous added the test-writing Issues related to unit or integration tests label Apr 12, 2022
@Connoropolous

This comment was marked as outdated.

Sign in to view
@Connoropolous Connoropolous changed the title test/specification has 9/13 assertions passing. Fix 4 failing assertions test/specification has 9/13(?) assertions passing. Fix at least 4 failing assertions Apr 13, 2022
@Connoropolous Connoropolous self-assigned this Apr 26, 2022
@Connoropolous Connoropolous changed the title test/specification has 9/13(?) assertions passing. Fix at least 4 failing assertions test/specification has 29/33(?) assertions passing. Fix at least 4 failing assertions Apr 26, 2022
@Connoropolous Connoropolous changed the title test/specification has 29/33(?) assertions passing. Fix at least 4 failing assertions test/specification has 32/35(?) assertions passing. Fix at least 4 failing assertions Apr 26, 2022
@Connoropolous Connoropolous changed the title test/specification has 32/35(?) assertions passing. Fix at least 4 failing assertions test/specification has 32/35(?) assertions passing. Fix at least 3 failing assertions Apr 26, 2022
Connoropolous added a commit that referenced this issue Apr 26, 2022
@Connoropolous
fix most of test/specification #249
7491cfe
@Connoropolous Connoropolous changed the title test/specification has 32/35(?) assertions passing. Fix at least 3 failing assertions test/specification has 40 passed/41(?) assertions passing. Fix at least 1 failing assertions Apr 26, 2022
@Connoropolous Connoropolous changed the title test/specification has 40 passed/41(?) assertions passing. Fix at least 1 failing assertions test/specification has 40 passed/41(?) assertions passing. Fix at least 1 failing assertions in specification/test_unit_crud.js Apr 26, 2022
@Connoropolous Connoropolous added the bug Something isn't working label Apr 26, 2022
pospi added a commit that referenced this issue May 16, 2022
@pospi
update logic for anchored records to encode string-based index paths …
887fd9a 
…into LinkTag

fixes Unit CRUD tests in #249 by allowing string IDs to be queried from the DHT again, after PathEntry changes made this impossible using Path construct
pospi added a commit that referenced this issue May 16, 2022
@pospi
#249 fix unit ID assertion in tests to factor in DnaHash portion of ID
a55571b
pospi added a commit that referenced this issue May 16, 2022
@pospi
fix wrong type used to constrain Unit deletion logic #249
7691ac2
@pospi
Copy link
Member

pospi commented May 16, 2022

Unit tests now fixed, completing this set of assertions.

@pospi pospi closed this as completed May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Connoropolous Connoropolous

Labels
bug Something isn't working test-writing Issues related to unit or integration tests
Projects
No open projects
MMR
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pospi @Connoropolous