Allow empty column lists in with clause and views

h2database · Jan 28, 2024 · 4505de3 · 4505de3
1 parent d07f3a0
commit 4505de3
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 3 deletions.
diff --git a/h2/src/docsrc/html/changelog.html b/h2/src/docsrc/html/changelog.html
@@ -21,6 +21,8 @@ <h1>Change Log</h1>
 
 <h2>Next Version (unreleased)</h2>
 <ul>
+<li>Issue #3987: Allow empty &lt;with column list&gt;
+</li>
 <li>Issue #822: WITH clauses' column aliases are not maintained correctly when selecting from CTE from within a derived
 table
 </li>

diff --git a/h2/src/main/org/h2/command/Parser.java b/h2/src/main/org/h2/command/Parser.java
@@ -1135,9 +1135,11 @@ private int parseSortType() {
 
     private String[] parseColumnList() {
         ArrayList<String> columns = Utils.newSmallArrayList();
-        do {
-            columns.add(readIdentifier());
-        } while (readIfMore());
+        if (!readIf(CLOSE_PAREN)) {
+            do {
+                columns.add(readIdentifier());
+            } while (readIfMore());
+        }
         return columns.toArray(new String[0]);
     }
 

diff --git a/h2/src/test/org/h2/test/scripts/ddl/createView.sql b/h2/src/test/org/h2/test/scripts/ddl/createView.sql
@@ -52,3 +52,15 @@ SELECT * FROM TEST_VIEW;
 
 DROP TABLE TEST CASCADE;
 > ok
+
+CREATE VIEW V() AS SELECT;
+> ok
+
+TABLE V;
+>
+>
+>
+> rows: 1
+
+DROP VIEW V;
+> ok
diff --git a/h2/src/test/org/h2/test/scripts/dml/with.sql b/h2/src/test/org/h2/test/scripts/dml/with.sql
@@ -246,3 +246,16 @@ SELECT A1.F1, A1.F2 FROM (SELECT * FROM T1) A1;
 > -- --
 > 1  2
 > rows: 1
+
+CREATE VIEW V AS
+WITH A AS (SELECT) TABLE A;
+> ok
+
+TABLE V;
+>
+>
+>
+> rows: 1
+
+DROP VIEW V;
+> ok