Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOUNDEX function should not be case-sensitive #3640

Closed
ullenboom opened this issue Oct 7, 2022 · 1 comment · Fixed by #3641
Closed

SOUNDEX function should not be case-sensitive #3640

ullenboom opened this issue Oct 7, 2022 · 1 comment · Fixed by #3641

Comments

@ullenboom
Copy link

Currently

select soundex('TOM'), soundex('tom')

is leading to T500 and t500.

The result should be uppper case, as you are referring to MS-SQL in the code anyway: https://learn.microsoft.com/en-us/sql/t-sql/functions/soundex-transact-sql?view=sql-server-ver16

@katzyn
Copy link
Contributor

katzyn commented Oct 8, 2022

This function is not expected to be compatible with other database systems, because they already have different implementations. I don't see any references to MS SQL in documentation or implementation of SOUNDEX (but implementation of DIFFERENCE mentions it together with HSQLDB).

Anyway, encoding of SOUNDEX shouldn't preserve the case of the first English letter, it's a zero day bug, but nobody cared before, possibly because this function is too specialized and is expected to be used only with English names and first letter of names is always capitalized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants