-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSVRead: Fails to translate empty Numbers, when cells are quoted #3785
Comments
CSV Number Columns can have empty Cells, e.g. '' which still need to be translated to a Number Column Type. So instead of creating a new Number from the empty String (which will fail), a NULL Number must be returned. fixes h2database#3785
Thank you so much for fast round turn. |
Andreas, we've never published snapshots. Where do you expect this artifact to live? |
Sorry, was not aware.
Sonatype? Publishing SNAPSHOT builds is pretty common these days. repositories {
maven {
name "ossrh"
def releasesRepoUrl = "https://s01.oss.sonatype.org/service/local/staging/deploy/maven2/"
def snapshotsRepoUrl= "https://s01.oss.sonatype.org/content/repositories/snapshots/"
url = version.endsWith('SNAPSHOT') ? snapshotsRepoUrl : releasesRepoUrl
credentials(PasswordCredentials)
}
|
Let me re-phrase: would you accept a PR modifying the build so that Snapshot get published on every commit to Master? |
@andreitokar We also have some leftovers from it it our build system: ffc00f8 |
Honestly, I have zero interest in doing that. As you might know, we have enough complains, when people switch to another released versions without a proper database upgrade. If you going to use snapshot release, then easy of use, like ability to download pre-built binary, should be the least of your worries. Will this snapshot be compatible with the previous one? What about the next? What went into that snapshot build? Does it have a feature X. |
Greetings. I have do not want to argue or annoy you, but it is worth pointing out: Snapshots are published automatically and whenever a change is committed to the Git Master. It takes Zero manual effort. "What went into that SNAPSHOT BUILD" --> everything committed to GIT Master, the SNAPSHOT bears the (latest) COMMIT ID and is distinct. Although I understand your point on the DB upgrade and compatibility. |
CSV File `sample.csv'
Import via
CsvRead
Will fail at row 2 with
Reason: the empty String
''
is not interpreted as NULL, but instead forwarded to a call ofnew BigDecimal('')
which will fail.The text was updated successfully, but these errors were encountered: