Call commit() when auto-commit is enabled

[nicoloboschi]

Resolution for #1927

[katzyn]

Thanks.

1. I think we need a separate error code (org.h2.api.ErrorCode) and some unified localized message (org.h2.res.*, h2/src/docsrc/textbase/_messages_en.prop) like Method {0} is not allowed when connection is in auto-commit mode.

2. It's very strange to disallow only the commit() method. At least no-arg rollback() should be disallowed too.

[grandinj]

This all looks very good, but the tests aren't testing the non-default case right now, I think we need:

    SysProperties.FORCE_AUTOCOMMIT_OFF_ON_COMMIT = true
    try {
        testCommitOnAutoCommitSet();
        testRollbackOnAutoCommitSet();
    } finally {
                SysProperties.FORCE_AUTOCOMMIT_OFF_ON_COMMIT = false;
    }
    testCommitOnAutoCommitSet();
    testRollbackOnAutoCommitSet();

to test both ways.

Thanks!

[nicoloboschi]

All SysProperties fields are "final", so I can't test it modifying FORCE_AUTOCOMMIT_OFF_ON_COMMIT value.
I cannot change the value using reflection because removing final modifier is not possible in JDK-12.
Aren't there any other cases like this in other tests?

[katzyn]

This field is not strongly required to be final, but if you want to preserve this modifier, take a look on org.h2.test.unit.TestMemoryUnmapper that spawns a child process. Don't forget to check its exit code.

[katzyn]

You need to pass -ea (to enable assertions) and -Dh2.forceAutoCommitOffOnCommit=true to the JVM and some argument to a program that can be used in the main(String[]) method to execute only the required method. In case of exception / error child process will be terminated with non-zero exit code and you can compare result of Process.waitFor() with zero to ensure that child process was terminated normally. TestMemoryUnmapper uses a more complicated logic with different exit codes that is not needed here.

[nicoloboschi]

i'll go removing final modifier

[katzyn]

Some minor issues.

[katzyn]

Please, send a license statement as described here:
https://h2database.com/html/build.html#providing_patches

It's better to send it to our mailing list:
https://groups.google.com/forum/#!forum/h2-database
Mailing list is partially pre-moderated, some new messages don't appear immediately.

[nicoloboschi]

Sorry, there he is: https://groups.google.com/forum/#!topic/h2-database/Jml94y8dSIw

[katzyn]

Thanks!