New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support of quotedNulls in CSV handling #3842
Conversation
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/h2database/h2database/3842.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diff Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/h2database/h2database/3842.diff | git apply Once you're satisfied, commit and push your changes in your project. Footnotes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Please address comments below and send a license statement as described here
https://h2database.com/html/build.html#providing_patches
to our mailing list:
https://groups.google.com/g/h2-database
(This list is partially pre-moderated, some new messages may appear only after review.)
h2/src/main/org/h2/expression/function/table/CSVReadFunction.java
Outdated
Show resolved
Hide resolved
Hi @katzyn, |
I think we need to wait a few weeks more, maybe there are other not yet reported regressions. |
Adds support for
quotedNulls
option inCSVREAD
andCSVWRITE
functions (see here) and reestablish previous behavior of CSV handling prior to 2.2.220.This should fix the breaking change introduced by #3786 and extends its feature since with this PR the handling of the
nullString
in CSV can be more finely adjusted.