Add JSR-310 Support #386
Merged
Add JSR-310 Support #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see lots of code duplications. Can you please move all the code you've added to a separate class |
|
I can do this.
|
marschall
force-pushed
the
jsr-310
branch
3 times, most recently
from
182877d
to
81bbe9d
Compare
svladykin
requested changes
Oct 29, 2016
| @@ -0,0 +1,481 @@ | |||
| package org.h2.util; | |||
| try { | ||
| return Class.forName(className); | ||
| } catch (ClassNotFoundException e) { | ||
| throw new IllegalStateException("Java 8 or later but class " + className + " is missing"); |
There was a problem hiding this comment.
Add the original ClassNotFoundException as cause.
| return clazz.getMethod(methodName, parameterTypes); | ||
| } catch (NoSuchMethodException e) { | ||
| throw new IllegalStateException("Java 8 or later but method " | ||
| + clazz.getName() + "#" + methodName + "(" + Arrays.toString(parameterTypes) + ") is missing"); |
There was a problem hiding this comment.
Add the original exception as cause.
| try { | ||
| return clazz.getField(fieldName).get(null); | ||
| } catch (NoSuchFieldException | IllegalAccessException e) { | ||
| throw new IllegalStateException("Java 8 or later but field " + clazz.getName() |
There was a problem hiding this comment.
Add the original exception as cause.
| } catch (IllegalAccessException e) { | ||
| throw DbException.convert(e); | ||
| } catch (InvocationTargetException e) { | ||
| throw DbException.convertInvocation(e, "timestampe conversion failed"); |
|
Looks very good now!
|
Add support for Java 8 Date and Time API AKA JSR-310. On the face of it the existing JDBC types java.sql.Date, java.sql.Time and java.sql.Timestamp offer conversion methods to and from JSR-310 data types. Unfortunately java.sql.Timestamp does silent data truncation when the timestamp falls into a DST transition on the JVM time zone. Worse still for java.time.OffsetDateTime there is no corresponding JDBC type. Therefore these conversions have to be implemented. All of this has to be programmed using reflection so the code compiles and can be executed on Java 7.
|
Thanks a lot for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Java 8 Date and Time API AKA JSR-310. On the face of it
the existing JDBC types java.sql.Date, java.sql.Time and
java.sql.Timestamp offer conversion methods to and from JSR-310 data
types. Unfortunately java.sql.Timestamp does silent data truncation
when the timestamp falls into a DST transition on the JVM time zone.
Worse still for java.time.OffsetDateTime there is no corresponding JDBC
type. Therefore these conversions have to be implemented. All of this
has to be programmed using reflection so the code compiles and can be
executed on Java 7.