Implement createArrayOf and setArray #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marschall
force-pushed
the
Connection-createArrayOf
branch
from
ad914be
to
a0f91e7
Compare
|
Looks good, but in some places ( Also it would be nice to have more extensive tests for null values, nested arrays, etc... |
|
I can do that, give me a moment. |
marschall
force-pushed
the
Connection-createArrayOf
branch
from
a0f91e7
to
9e86716
Compare
Currently java.sql.Array is only supported when returned from the database. Passing arrays to the database is not supported. Connection#createArrayOf, PreparedStatement#setArray and PreparedStatement#setObject with a java.sql.Array are not supported. This pull requests implements passing java.sql.Array objects to the database and includes the following changes: - implement Connection#createArrayOf - implement PreparedStatement#setArray - implement array support in ResultSet#getObject - implement conversion from java.sql.Array to Value - update DataType#convertTo to support arrays as well - add tests for #createArrayOf, #setArray and #setObject - add tests for #getObject with an array argument - remove the test for Connection#createArrayOf being unsupported - remove the test for PreparedStatement#setArray being unsupported The typeName passed to #createArrayOf is ignored, this is in accordance with JdbcArray#getBaseTypeName returning "NULL" and JdbcArray#getBaseType returning Types.NULL even if the backing array is homogeneous.
marschall
force-pushed
the
Connection-createArrayOf
branch
from
9e86716
to
3143a1e
Compare
|
@svladykin I changed |
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently java.sql.Array is only supported when returned from the
database. Passing arrays to the database is not supported.
Connection#createArrayOf, PreparedStatement#setArray and
PreparedStatement#setObject with a java.sql.Array are not supported.
This pull requests implements passing java.sql.Array objects to the
database and includes the following changes:
The typeName passed to #createArrayOf is ignored, this is in accordance
with JdbcArray#getBaseTypeName returning "NULL" and
JdbcArray#getBaseType returning Types.NULL even if the backing array is
homogeneous.