-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add position and allow 0 margin for text watermark #343
base: master
Are you sure you want to change the base?
Conversation
* fix text position * refactor code line
Hey, that's great! Just dropping in to say two things:
|
@Eptarch ok, i will add tests for it, figured out this solution because my project need this functionality too. i just realize there are related issues with this pr |
Any plans on merging this? |
please merge~ |
bump |
Hi @fajrifernanda, did you add some tests to your project later? |
Oh~~~ This branch has conflicts that must be resolved now, after more than three years. |
Hi again @fajrifernanda, would you submit your PR to https://github.com/suntong/bimg/tree/dev as well please? |
NVM, I got it -- suntong@44218a7 |
Add position(left and top) to set the position of text watermark
and allow 0 margin on text watermark
this is sample of 0 margin, left(0), top(imageheight-fontheight)