Add context expiration cancellation support #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make gock behave the same as the standard HTTP client when it comes to request context behavior.
http.NewRequestWithContext was introduced in go v1.13 so that is now the minimum required version. Also remove unused modules via go mod tidy.
|
Thanks! Would you mind fixing the formatting issue? https://travis-ci.org/github/h2non/gock/jobs/772774065#L283-L322 |
|
Done. Sorry about that. Let me know if you need anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for expired and cancelled contexts, both with and without delay operations. This should make the behavior of gock mocks more similar to actual HTTP upstreams using the standard HTTP client.
Note that this change fundamentally requires go version 1.13 or greater. As such,
go.modwas updated accordingly.Resolves #84