Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build fix under solaris based oses : #1300

Merged
merged 1 commit into from
May 24, 2017
Merged

build fix under solaris based oses : #1300

merged 1 commit into from
May 24, 2017

Conversation

devnexen
Copy link
Contributor

  • "Initialiser in not constant". related to the pthread barrier conf field.
  • Initialising it in main instead.

- "Initialiser in not constant". related to the pthread barrier conf field.
- Initialising it in main instead.
@deweerdt
Copy link
Member

I can't reproduce the issue with Solaris 11 and gcc 4.8.2, which compiler were you using?

@devnexen
Copy link
Contributor Author

openindiana and gcc-4.4.4

@devnexen
Copy link
Contributor Author

devnexen commented May 17, 2017

In fact I "trickered" by changing one header file in libyrcmds to detect properly the operating system (change merged in the related github project now), and this change to make it work.

@deweerdt
Copy link
Member

The change looks good to me. I suspect that the compiler balks at initializing struct members. If we used c99, we could use named initializers to make the issue go away (since POSIX mandates that SIZE_MAX, PTHREAD_MUTEX_INITIALIZER, and PTHREAD_COND_INITIALIZER all be constant suitable for static initialization).

@kazuho kazuho merged commit 4403bd7 into h2o:master May 24, 2017
@kazuho
Copy link
Member

kazuho commented May 24, 2017

Thank you for the fix!

kazuho added a commit that referenced this pull request Jun 2, 2017
This reverts commit 4403bd7, reversing
changes made to 1e4111d.
@kazuho kazuho mentioned this pull request Jun 2, 2017
yannick pushed a commit to tamediadigital/h2o that referenced this pull request Jun 13, 2017
This reverts commit 4403bd7, reversing
changes made to 1e4111d.
kazuho added a commit that referenced this pull request Oct 12, 2017
build fix under solaris based oses :
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants