Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly handle window size becoming negative #1582

Merged
merged 2 commits into from Dec 29, 2017

Conversation

kazuho
Copy link
Member

@kazuho kazuho commented Dec 28, 2017

Fix bug found by h2spec version: 2.1.0 (d99d17171179c709cf23a3df1aadc9657addf825).

@kazuho kazuho added the http2 label Dec 28, 2017
…active; we already allow misfiring the proceed callback when the window is zero-sized
@kazuho
Copy link
Member Author

kazuho commented Jan 5, 2018

Thanks to @Etsukata for noticing this separately and proposing some of the changes in #1526 that have gone in to master in through this PR.

kazuho added a commit that referenced this pull request Apr 25, 2018
correctly handle window size becoming negative
joemfb added a commit to joemfb/h2o that referenced this pull request Jul 18, 2018
* tag 'v2.2.5': (37 commits)
  releng for 2.2.5
  update Changes
  extract https://github.com/h2o/neverbleed @ 1e9b518 () at deps/neverbleed
  Update line_end when reallocating a buffer for logging
  Merge pull request h2o#1718 from h2o/kazuho/tls13-26
  Merge pull request h2o#1485 from h2o/kazuho/update-picotls-2
  Merge pull request h2o#1707 from fetus-hina/libressl_2.7
  Merge pull request h2o#1545 from h2o/i110/fix-sock-bytes-written
  Merge pull request h2o#1716 with tweaks
  Merge pull request h2o#1662 from h2o/i110/mruby-fix-preload-require-path
  Merge pull request h2o#1310 from deweerdt/deweerdt/x-http2-push-only-support-for-mruby
  Merge pull request h2o#1587 from h2o/kazuho/amend-1582
  Merge pull request h2o#1582 from h2o/kazuho/h2-negative-window
  Merge pull request h2o#1579 from h2o/kazuho/http2/ignore-reserved-bit-of-frame-header
  Merge pull request h2o#1555 from h2o/i110/stop-opening-new-push-streams-after-goaway
  Merge pull request h2o#1389 from jbenoist/master
  Merge pull request h2o#1650 from h2o/i110/append-index-file-name-to-script-name
  releng for 2.2.4
  update Changes
  regen doc
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant