Don't compress cookie/set-cookie headers #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbenoist could you please add test coverage, now that h2get has displays a list of compressed headers? |
|
Sorry for the belated response. I think that this is a good change. However we might be afraid of keeping too many things not being compressed. Could we follow what Firefox does, i.e. keep cookies longer than 20 bytes as they are? |
- Limit the feature to fields of length < 20-bytes
|
Thank you for the changes! (And did you rebase the pull request fixing the conflicts? Thank you for the effort). The PR has been merged to master. |
kazuho
added a commit
that referenced
this pull request
Apr 25, 2018
Don't compress cookie/set-cookie headers
joemfb
added a commit
to joemfb/h2o
that referenced
this pull request
Jul 18, 2018
* tag 'v2.2.5': (37 commits) releng for 2.2.5 update Changes extract https://github.com/h2o/neverbleed @ 1e9b518 () at deps/neverbleed Update line_end when reallocating a buffer for logging Merge pull request h2o#1718 from h2o/kazuho/tls13-26 Merge pull request h2o#1485 from h2o/kazuho/update-picotls-2 Merge pull request h2o#1707 from fetus-hina/libressl_2.7 Merge pull request h2o#1545 from h2o/i110/fix-sock-bytes-written Merge pull request h2o#1716 with tweaks Merge pull request h2o#1662 from h2o/i110/mruby-fix-preload-require-path Merge pull request h2o#1310 from deweerdt/deweerdt/x-http2-push-only-support-for-mruby Merge pull request h2o#1587 from h2o/kazuho/amend-1582 Merge pull request h2o#1582 from h2o/kazuho/h2-negative-window Merge pull request h2o#1579 from h2o/kazuho/http2/ignore-reserved-bit-of-frame-header Merge pull request h2o#1555 from h2o/i110/stop-opening-new-push-streams-after-goaway Merge pull request h2o#1389 from jbenoist/master Merge pull request h2o#1650 from h2o/i110/append-index-file-name-to-script-name releng for 2.2.4 update Changes regen doc ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain headers are suspected of being risky to compress as they might just make table probing much too easy, see:
https://http2.github.io/http2-spec/compression.html#Security
This change marks 'cookie/set-cookie' as such and ensures h2o wont compress or index them.