Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass proper timeout value to uv_timer_start #1911

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Conversation

i110
Copy link
Contributor

@i110 i110 commented Nov 20, 2018

if you use libuv, h2o_timer never gets fired unless you wait 18 days.. lol

@i110 i110 requested a review from kazuho November 20, 2018 20:15
@kazuho
Copy link
Member

kazuho commented Nov 20, 2018

Thank you for noticing this. Looks like a regression caused by #1840.

@kazuho kazuho merged commit 0d3ab92 into master Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants