implement our own "once" function #2086
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My affection to using closures instead of declaring callbacks (and global variables) is strong enough to define a replacement for
pthread_once
function that takes a closure as an argument.Actually, this PR fixes theoretical race conditions in some of the initialization code that we run. 9c06f68 addresses two cases where an "index" might be used by a different thread, before the objects that are being referred to by that "index" is being written to memory.