Explicitly link against WSLAY when available #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazuho
reviewed
Dec 12, 2019
|
I've just had another look, pkg-config is not the right place to add this. It only fixed it because there was a symptom of libh2o-evloop not linking against it which was "fixed" by getting dnsdist to include it in its linker. I'll modify my fix and push out an update to this branch :) |
When other libraries attempt to link against libh2o and libh2o-evloop that was compiled with libwslay available, there are errors from missing symbols associated with code which makes use of the wslay library. To rectify this, explicitly link against libwslay during the build process. Fixes h2o#2105 Signed-off-by: James Taylor <james@jtaylor.id.au>
James-TR
force-pushed
the
fix/libh2o-evloop-link
branch
from
527fb1a
to
f7d5cb8
Compare
James-TR
changed the title
|
I wasn't sure if putting the link to WSLAY_LIBRARIES into EXTRA_LIBS would break anything so I explicitly added it to the libh2o and libh2o-evloop targets. This compiles fine on my end and I was able to link against the library correctly with dnsdist. |
|
Thanks the changes looks fine to me. Merged. |
James-TR
added a commit
to James-TR/openwrt-packages
that referenced
this pull request
Dec 13, 2019
Update wslay link patch with upstream fix from h2o/h2o#2196 Signed-off-by: James Taylor <james@jtaylor.id.au>
shashank2907
pushed a commit
to shashank2907/packages
that referenced
this pull request
Feb 23, 2020
Update wslay link patch with upstream fix from h2o/h2o#2196 Signed-off-by: James Taylor <james@jtaylor.id.au>
shogo82148
added a commit
to shogo82148/h2o-rpm
that referenced
this pull request
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When other libraries attempt to link against libh2o and libh2o-evloop that was
compiled with libwslay available, there are errors from missing symbols
associated with code which makes use of the wslay library. To rectify this,
explicitly link against libwslay during the build process.
Fixes #2105
Signed-off-by: James Taylor james@jtaylor.id.au