do not send PUSH_PROMISE if the push is cancelled for a synchronous handler
#486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ronous handler (e.g. file handler)
kazuho
added a commit
that referenced
this pull request
Sep 8, 2015
…when-cancelling-sync-handler do not send `PUSH_PROMISE` if the push is cancelled for a synchronous handler
|
note: regression in #421 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially in case of cache-aware server push, pushed requests are often cancelled. However, even in such case the server was sending
PUSH_PROMISEframe if the handler that served the request was running synchronously (e.g. file handler).This PR fixes the issue.