Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change CMAKE_MINIMUM_REQUIRED to 2.8.11 #594

Merged
merged 1 commit into from
Nov 17, 2015
Merged

change CMAKE_MINIMUM_REQUIRED to 2.8.11 #594

merged 1 commit into from
Nov 17, 2015

Conversation

kazuho
Copy link
Member

@kazuho kazuho commented Nov 17, 2015

  • fact: CMake provided by CentOS 7 is 2.8.11.
  • fact: TARGET_INCLUDE_DIRECTORIES was introduced in 2.8.11 (http://www.kitware.com/blog/home/post/492)
  • looking at the source code diff I anticipate there is no issue that affect H2O on using CMake 2.8.11

kazuho added a commit that referenced this pull request Nov 17, 2015
@kazuho
Merge pull request #594 from h2o/kazuho/allow-cmake-2.8.11
4bf25d5 
change CMAKE_MINIMUM_REQUIRED to 2.8.11
@kazuho kazuho merged commit 4bf25d5 into master Nov 17, 2015
kazuho added a commit that referenced this pull request Nov 17, 2015
@kazuho
Merge pull request #594 from h2o/kazuho/allow-cmake-2.8.11
3b1e5a6 
change CMAKE_MINIMUM_REQUIRED to 2.8.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kazuho