Add error logging in on_body #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -312,7 +312,9 @@ static int on_body(h2o_http1client_t *client, const char *errstr) | |||
| /* FIXME should there be a way to notify error downstream? */ | |||
|
|
|||
| if (errstr != NULL) { | |||
| /* detach the content */ | |||
| if (errstr != h2o_http1client_error_is_eos) { | |||
| h2o_req_log_error(req, "lib/core/proxy.c", "%s", errstr); | |||
There was a problem hiding this comment.
Maybe req should be self->src_req?
There was a problem hiding this comment.
Yes, of course, it's fixed now. Thanks!
Log and error when hitting a non eos error in `proxy.c:on_body()`
deweerdt
force-pushed
the
deweerdt/error_logging_proxy_on_body
branch
from
96fc178
to
2aaea00
Compare
|
Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log and error when hitting a non eos error in
proxy.c:on_body()