Allow to disable libuv even when it is found #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not currently possible to tell cmake to ignore libuv if it was found on the system. This add a 'DISABLE_LIBUV' variable (defaults to OFF), if set, it won't compile any libuv related dependency. We also move the compilation of unit tests that depend on libuv under `LIBUV_FOUND` Finally, this patch replaces `INFO` with `STATUS` as the first argument of cmake's `MESSAGE` function. See: https://cmake.org/cmake/help/v3.6/command/message.html
|
Thank you for the PR! LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not currently possible to tell cmake to ignore libuv if it was
found on the system. This add a 'DISABLE_LIBUV' variable (defaults to
OFF), if set, it won't compile any libuv related dependency.
We also move the compilation of unit tests that depend on libuv under
LIBUV_FOUNDFinally, this patch replaces
INFOwithSTATUSas the first argumentof cmake's
MESSAGEfunction. See:https://cmake.org/cmake/help/v3.6/command/message.html