Workaround 5.0 asan findings #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make 16 the arrays explicitly 16 bytes large so that reads exceeding them aren't flag as out of bounds reads
|
I don't believe it's necessary to pull the change, but i figured that i would at least document the fact that ASAN reports out-of-bounds reads on |
kazuho
added a commit
that referenced
this pull request
May 17, 2019
Fix theoretical SEGV concern (Workaround 5.0 asan findings)
|
Thanks for the PR. I think we have a theoretical possibility of seeing SEGV due to Hence merged with cc4df34 being added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make 16 the arrays explicitly 16 bytes large so that reads exceeding
them aren't flag as out of bounds reads